feat(ts): stack and queue implementation #775
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
berquist
added
Implementation
|
thanks for the implementation; however, we do not yet have a chapter with code for stacks and queues. This will be updated soon, so I'll keep this PR in mind as we write the text for that section #771 has a similar issue, so hopefully we can work everything out! |
ntindle
reviewed
Aug 21, 2021
| front(): T; | ||
| } | ||
|
|
||
| class Queue<T> implements IQueue<T> { |
There was a problem hiding this comment.
@leios do we have standards for TypeHinting in the interface names?
There was a problem hiding this comment.
I don't think so. Maybe we should add something to the code style guide?
leios
approved these changes
Aug 23, 2021
| front(): T; | ||
| } | ||
|
|
||
| class Queue<T> implements IQueue<T> { |
There was a problem hiding this comment.
I don't think so. Maybe we should add something to the code style guide?
|
I will go ahead and merge this now and then put the infrastructure in another PR to solve issue #838 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.